Skip to content

chore: remove gitleaks file and add it into build#667

Merged
AhmedAmineZr merged 3 commits intodevelopfrom
666-improvementtools-improve-github-workflow
Apr 20, 2026
Merged

chore: remove gitleaks file and add it into build#667
AhmedAmineZr merged 3 commits intodevelopfrom
666-improvementtools-improve-github-workflow

Conversation

@AhmedAmineZr
Copy link
Copy Markdown
Member

@AhmedAmineZr AhmedAmineZr commented Apr 18, 2026

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@AhmedAmineZr AhmedAmineZr requested a review from nouha06 April 18, 2026 12:41
@AhmedAmineZr AhmedAmineZr self-assigned this Apr 18, 2026
@AhmedAmineZr AhmedAmineZr linked an issue Apr 18, 2026 that may be closed by this pull request
[Improvement][Tools] Improve GitHub workflow #666
Closed
@AhmedAmineZr AhmedAmineZr force-pushed the 666-improvementtools-improve-github-workflow branch from bde3887 to 15b35e8 Compare April 18, 2026 13:18
@AhmedAmineZr AhmedAmineZr force-pushed the 666-improvementtools-improve-github-workflow branch from 15b35e8 to 57526eb Compare April 18, 2026 13:23
nouha06
nouha06 previously requested changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nouha06 nouha06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to add this ticket in changelog

@nouha06 nouha06 self-requested a review April 20, 2026 13:27
@nouha06 nouha06 dismissed their stale review April 20, 2026 13:28

wrong

@AhmedAmineZr AhmedAmineZr merged commit 05104d7 into develop Apr 20, 2026
11 checks passed
@AhmedAmineZr AhmedAmineZr deleted the 666-improvementtools-improve-github-workflow branch April 20, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nouha06 nouha06 nouha06 approved these changes

Assignees

@AhmedAmineZr AhmedAmineZr

Labels

🧩 enhancement New feature or request 🚨 security 🛠️ technical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Improvement][Tools] Improve GitHub workflow

2 participants

@AhmedAmineZr @nouha06